Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk update deprecated authenticators #40549

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jun 26, 2024

What

Updates a number of our source connectors still using the deprecated auth package from the Python CDK. In some cases the connector was already migrated but still using the deprecated package in tests. These are the connectors that pass acceptance tests out the gate:

  • Gridly
  • Jira
  • Linnworks
  • Mixpanel
  • Pardot
  • RD Station Marketing
  • SurveyMonkey
  • US Census
  • Weatherstack
  • Webflow

The full list of remaining sources to migrate is listed here:

How

  • Replaces the auth package with requests_native_auth
  • Replaces references to authenticator attribute with _session.auth
  • Replaces usage of NoAuth() (mostly in tests) with authenticator=None
  • Updated a couple docs/example references to the old package

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 5:59pm

@ChristoGrab ChristoGrab marked this pull request as ready for review June 26, 2024 17:40
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky you, all 🟢 CI! I'd otherwise advise to create per connector PR with airbyte-ci connectors pull-request.

@ChristoGrab ChristoGrab merged commit ffca542 into master Jun 26, 2024
49 checks passed
@ChristoGrab ChristoGrab deleted the christo/bulk-authenticator-update branch June 26, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants