-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk update deprecated authenticators #40549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/linnworks
connectors/source/mixpanel
connectors/source/surveymonkey
connectors/source/us-census
connectors/source/jira
connectors/source/pardot
connectors/source/webflow
connectors/source/weatherstack
connectors/source/rd-station-marketing
connectors/source/gridly
connectors/source/python-http-tutorial
labels
Jun 26, 2024
…m/airbytehq/airbyte into christo/bulk-authenticator-update
alafanechere
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lucky you, all 🟢 CI! I'd otherwise advise to create per connector PR with airbyte-ci connectors pull-request
.
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/gridly
connectors/source/jira
connectors/source/linnworks
connectors/source/mixpanel
connectors/source/pardot
connectors/source/python-http-tutorial
connectors/source/rd-station-marketing
connectors/source/surveymonkey
connectors/source/us-census
connectors/source/weatherstack
connectors/source/webflow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates a number of our source connectors still using the deprecated
auth
package from the Python CDK. In some cases the connector was already migrated but still using the deprecated package in tests. These are the connectors that pass acceptance tests out the gate:The full list of remaining sources to migrate is listed here:
How
auth
package withrequests_native_auth
authenticator
attribute with_session.auth
NoAuth()
(mostly in tests) withauthenticator=None
Can this PR be safely reverted and rolled back?