-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destination-s3: convert prod code to kotlin #40574
Merged
stephane-airbyte
merged 1 commit into
master
from
stephane/06-26-destination-s3_convert_prod_code_to_java
Jun 27, 2024
Merged
destination-s3: convert prod code to kotlin #40574
stephane-airbyte
merged 1 commit into
master
from
stephane/06-26-destination-s3_convert_prod_code_to_java
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
stephane-airbyte
changed the title
destination-s3: convert prod code to java
destination-s3: convert prod code to kotlin
Jun 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on Graphite |
2 tasks
stephane-airbyte
force-pushed
the
stephane/06-26-destination-s3_convert_prod_code_to_java
branch
from
June 27, 2024 16:56
642a7c6
to
bc60c66
Compare
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Jun 27, 2024
stephane-airbyte
requested review from
edgao and
johnny-schmidt
and removed request for
a team
June 27, 2024 16:56
edgao
approved these changes
Jun 27, 2024
@@ -514,6 +514,7 @@ To see connector limitations, or troubleshoot your S3 connector, see more [in ou | |||
|
|||
| Version | Date | Pull Request | Subject | | |||
| :------ | :--------- | :--------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| 0.6.3 | 2024-04-15 | [38204](https://github.com/airbytehq/airbyte/pull/38204) | convert all production code to kotlin | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr id is 40574?
Merge activity
|
stephane-airbyte
deleted the
stephane/06-26-destination-s3_convert_prod_code_to_java
branch
June 27, 2024 20:38
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
## What <!-- * Describe what the change is solving. Link all GitHub issues related to this change. --> ## How <!-- * Describe how code changes achieve the solution. --> ## Review guide <!-- 1. `x.py` 2. `y.py` --> ## User Impact <!-- * What is the end result perceived by the user? * If there are negative side effects, please list them. --> ## Can this PR be safely reverted and rolled back? <!-- * If unsure, leave it blank. --> - [ ] YES π - [ ] NO β
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/destination/s3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?