Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-s3: convert prod code to kotlin #40574

Conversation

stephane-airbyte
Copy link
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 27, 2024 5:00pm

@stephane-airbyte stephane-airbyte changed the title destination-s3: convert prod code to java destination-s3: convert prod code to kotlin Jun 27, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte force-pushed the stephane/06-26-destination-s3_convert_prod_code_to_java branch from 642a7c6 to bc60c66 Compare June 27, 2024 16:56
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 27, 2024
@stephane-airbyte stephane-airbyte marked this pull request as ready for review June 27, 2024 16:56
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner June 27, 2024 16:56
@stephane-airbyte stephane-airbyte requested review from edgao and johnny-schmidt and removed request for a team June 27, 2024 16:56
@@ -514,6 +514,7 @@ To see connector limitations, or troubleshoot your S3 connector, see more [in ou

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :--------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------- |
| 0.6.3 | 2024-04-15 | [38204](https://github.com/airbytehq/airbyte/pull/38204) | convert all production code to kotlin |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr id is 40574?

Copy link
Contributor Author

stephane-airbyte commented Jun 27, 2024

Merge activity

@stephane-airbyte stephane-airbyte merged commit 4b3d780 into master Jun 27, 2024
36 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/06-26-destination-s3_convert_prod_code_to_java branch June 27, 2024 20:38
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
## What
<!--
* Describe what the change is solving. Link all GitHub issues related to this change.
-->

## How
<!--
* Describe how code changes achieve the solution.
-->

## Review guide
<!--
1. `x.py`
2. `y.py`
-->

## User Impact
<!--
* What is the end result perceived by the user?
* If there are negative side effects, please list them. 
-->

## Can this PR be safely reverted and rolled back?
<!--
* If unsure, leave it blank.
-->
- [ ] YES πŸ’š
- [ ] NO ❌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants