docs: add abctl download buttons with fallback with link to release page #41975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 64faf69.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
cgardens
changed the title
bgroff
approved these changes
Jul 16, 2024
cgardens
deleted the
revert-41671-revert-41613-cgardens/linux-abctl-download-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the original PR #41613 was that there were cases where the user would need to do a hard reload to get the javascript to run. The problem with that is that the fallback for if we couldn't get the abctl releases was also handled by the javascript. That left the user stuck if they didn't think to do a hard refresh. This new version hardcodes the fallback logic into the html so that if there javascript doesn't run, the degraded experience of just being a link to the github releases page is guaranteed to be possible.