-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java CDK] Fix java interop compilation issue in Config/TransientErrorException. #41996
Changes from 8 commits
94498c7
c15f22e
dd5ebb6
2da5a7b
00a8a2b
33bdbbc
5cb741f
b1981fc
23106bf
978bd19
a33d79f
387809c
5900516
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
version=0.41.4 | ||
version=0.41.5 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -213,6 +213,11 @@ public void close() throws Exception { | |
} | ||
} | ||
|
||
@Override | ||
public Optional<AirbyteStreamNameNamespacePair> getAirbyteStream() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the problem/ticket resulting from the lack of this implementation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default implementation of I noticed this during testing that we were throwing a NoSuchElementException instead of the relevant TransientException There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is a similar change required on other connectors? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. That will have been reflected in the PRs associated with WASS changes in the relevant connectors |
||
return Optional.of(pair); | ||
} | ||
|
||
private boolean isCdcSync(MySqlInitialLoadStateManager initialLoadStateManager) { | ||
if (initialLoadStateManager instanceof MySqlInitialLoadGlobalStateManager) { | ||
LOGGER.info("Running a cdc sync"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that due to #41647 DebeziumRecordIterator.isHeartbeatEvent() is currently broken.
Not sure if limited to a driver or a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this PR wont help that case. Then again it won't handle or make anything worse.