-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(airbyte-cdk): deprecate availability strategy #42039
Merged
artem1205
merged 5 commits into
master
from
artem1205/airbyte-cdk-remove-availability-strategy-8521
Jul 23, 2024
Merged
refactor!(airbyte-cdk): deprecate availability strategy #42039
artem1205
merged 5 commits into
master
from
artem1205/airbyte-cdk-remove-availability-strategy-8521
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…205/airbyte-cdk-remove-availability-strategy-8521 # Conflicts: # airbyte-cdk/python/airbyte_cdk/sources/streams/core.py # airbyte-cdk/python/airbyte_cdk/sources/streams/http/http.py
…205/airbyte-cdk-remove-availability-strategy-8521 # Conflicts: # airbyte-cdk/python/airbyte_cdk/sources/streams/utils/stream_helper.py
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
lazebnyi
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Collaborator
Author
/approve-regression-tests
|
artem1205
deleted the
artem1205/airbyte-cdk-remove-availability-strategy-8521
branch
July 23, 2024 08:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/8521
How
remove availability strategy
decided to leave some classes, because they are used in check_connection for
filebased
andconcurrent
sources.Review guide
airbyte-cdk/python/airbyte_cdk/sources/declarative/checks/check_stream.py
airbyte-cdk/python/airbyte_cdk/sources/streams/availability_strategy.py
airbyte-cdk/python/airbyte_cdk/sources/streams/core.py
airbyte-cdk/python/airbyte_cdk/sources/streams/http/availability_strategy.py
User Impact
Can this PR be safely reverted and rolled back?