Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(airbyte-cdk): deprecate availability strategy #42039

Merged

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jul 17, 2024

What

Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/8521

How

remove availability strategy
decided to leave some classes, because they are used in check_connection for filebased and concurrent sources.

Review guide

  1. airbyte-cdk/python/airbyte_cdk/sources/declarative/checks/check_stream.py
  2. airbyte-cdk/python/airbyte_cdk/sources/streams/availability_strategy.py
  3. airbyte-cdk/python/airbyte_cdk/sources/streams/core.py
  4. airbyte-cdk/python/airbyte_cdk/sources/streams/http/availability_strategy.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 8:48pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jul 17, 2024
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…205/airbyte-cdk-remove-availability-strategy-8521

# Conflicts:
#	airbyte-cdk/python/airbyte_cdk/sources/streams/core.py
#	airbyte-cdk/python/airbyte_cdk/sources/streams/http/http.py
@artem1205 artem1205 self-assigned this Jul 18, 2024
@artem1205 artem1205 marked this pull request as ready for review July 18, 2024 12:32
@artem1205 artem1205 requested a review from a team July 18, 2024 13:22
…205/airbyte-cdk-remove-availability-strategy-8521

# Conflicts:
#	airbyte-cdk/python/airbyte_cdk/sources/streams/utils/stream_helper.py
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artem1205
Copy link
Collaborator Author

artem1205 commented Jul 23, 2024

/approve-regression-tests

Check job output.

✅ Approving regression tests

@artem1205 artem1205 merged commit 5056e67 into master Jul 23, 2024
32 of 34 checks passed
@artem1205 artem1205 deleted the artem1205/airbyte-cdk-remove-availability-strategy-8521 branch July 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants