Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Shopify: fixed store redirection, add bulk checkpointing #42095

Merged
merged 46 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
ef41bf9
test
bazarnov Jul 11, 2024
edd3ee8
Merge remote-tracking branch 'origin/master'
bazarnov Jul 11, 2024
cb299d0
Merge remote-tracking branch 'origin/master'
bazarnov Jul 13, 2024
adcae54
Merge branch 'master' of https://github.com/airbytehq/airbyte
bazarnov Jul 16, 2024
5057187
Merge remote-tracking branch 'origin/master'
bazarnov Jul 16, 2024
7203d14
Merge remote-tracking branch 'origin/master'
bazarnov Jul 16, 2024
2a8143d
Merge remote-tracking branch 'origin/master'
bazarnov Jul 17, 2024
f71eb18
Merge remote-tracking branch 'origin/master'
bazarnov Jul 17, 2024
706d507
added checkpointing to BULK
bazarnov Jul 17, 2024
aa9b31e
added url_base switch to redirect
bazarnov Jul 18, 2024
598a1a1
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 18, 2024
dfb71c7
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 18, 2024
f03bf11
updated and formated
bazarnov Jul 18, 2024
d809c17
updated changelog
bazarnov Jul 18, 2024
958cdbe
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 19, 2024
67e23f8
updated after review
bazarnov Jul 19, 2024
d2a2812
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 19, 2024
6268a18
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 22, 2024
aff67d6
added more BULK related info to the log messages, changed the min val…
bazarnov Jul 22, 2024
af063d1
added default ASC sorting for BUlk streams
bazarnov Jul 22, 2024
f0864d4
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 22, 2024
edfe43f
formatted
bazarnov Jul 22, 2024
260bdcc
reverted .dockerignore
bazarnov Jul 22, 2024
f5fbbc7
reverted non-functional changes
bazarnov Jul 22, 2024
e04faed
fixed unit_tests up to the changes
bazarnov Jul 22, 2024
e3a1c41
formatted
bazarnov Jul 22, 2024
b8493f6
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 22, 2024
908a119
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 22, 2024
0b6c107
updated
bazarnov Jul 23, 2024
87b923f
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 23, 2024
e720941
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 23, 2024
14eb8c8
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 23, 2024
1883317
fixed inf.loop
bazarnov Jul 23, 2024
7162a62
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 23, 2024
a506fd3
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 24, 2024
b499cb0
minor corrections
bazarnov Jul 24, 2024
123792f
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 24, 2024
521ad5a
updated
bazarnov Jul 25, 2024
3bb28dc
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 25, 2024
8d51e42
updated CAT config
bazarnov Jul 25, 2024
25cb146
updated switch url logic
bazarnov Jul 25, 2024
85b7b21
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 26, 2024
6e39a8f
fixed default behaviour for pres.prices
bazarnov Jul 26, 2024
756b892
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 29, 2024
db50cfe
bumped version
bazarnov Jul 29, 2024
366fa1b
Merge remote-tracking branch 'origin/master' into baz/source/shopify/…
bazarnov Jul 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ acceptance_tests:
spec:
tests:
- spec_path: "source_shopify/spec.json"
backward_compatibility_tests_config:
# This is the intentional change.
# Added new field `job_checkpoint_interval`,
# to provide the ability to override this value by the User.
disable_for_version: 2.4.14
connection:
tests:
- config_path: "secrets/config.json"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 9da77001-af33-4bcd-be46-6252bf9342b9
dockerImageTag: 2.4.14
dockerImageTag: 2.4.15
dockerRepository: airbyte/source-shopify
documentationUrl: https://docs.airbyte.com/integrations/sources/shopify
githubIssueLabel: source-shopify
Expand Down
18 changes: 9 additions & 9 deletions airbyte-integrations/connectors/source-shopify/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "2.4.14"
version = "2.4.15"
name = "source-shopify"
description = "Source CDK implementation for Shopify."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ class BulkJobCreationFailedConcurrentError(BaseBulkException):

failure_type: FailureType = FailureType.transient_error

class BulkJobRedirectToOtherShopError(BaseBulkException):
"""Raised when the response contains another shop name"""

failure_type: FailureType = FailureType.transient_error

class BulkJobConcurrentError(BaseBulkException):
"""Raised when failing the job after hitting too many BulkJobCreationFailedConcurrentError."""

Expand Down
Loading
Loading