Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard op code m change events #42431

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Jul 23, 2024

What

Fixes #41647
Debezium change events are coming with an operation code.
Op code "m" signifies a "message" event that is irrelevant for syncing as it contains no before or after data.
In this case a 3rd party wrote arbitrary messages into the WAL log which caused us to fail parsing.
We want to only handle known event types.

How

Discard debezium change events that has op: m.

User Impact

Should not impact users as it should unblock cases a message event breaks us.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@rodireich rodireich linked an issue Jul 23, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 4:19pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres labels Jul 23, 2024
@rodireich rodireich changed the title 41647 discard op m changeevent 41647 discard op code m change events Jul 23, 2024
@rodireich rodireich changed the title 41647 discard op code m change events Discard op code m change events Jul 23, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 23, 2024
@rodireich rodireich marked this pull request as ready for review July 23, 2024 07:07
@rodireich rodireich requested review from a team as code owners July 23, 2024 07:07
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

It looks like other DBs can have the same issue, but we can republish those later - Postgres has the issue now.

rodireich and others added 3 commits July 23, 2024 08:42
…byte/cdk/integrations/debezium/internals/DebeziumRecordIterator.kt

Co-authored-by: Evan Tahler <evan@airbyte.io>
@rodireich
Copy link
Contributor Author

rodireich commented Jul 23, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10062103687
✅ Successfully published Java CDK version=0.43.2!

@rodireich rodireich merged commit 2a6d6e8 into master Jul 23, 2024
34 checks passed
@rodireich rodireich deleted the 41647-discard-op-m-changeevent branch July 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debezium heartbeat not identified correctly
3 participants