docs: add version after which connector secrets are deleted. #42515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
keyihuang
approved these changes
Jul 24, 2024
Adorism
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Non-blocking, but I suggest moving the version to the beginning of this statement to draw attention to the differentiating factor. What is the behavior related to secrets in versions prior to the one you cite? Would secrets need to be manually deleted if someone were using an older version and either deleted or updated their connection?
| @@ -61,3 +61,4 @@ E.g. `airbyte_workspace_024eaa40-75ae-4014-941d-b9e938c3a363_secret_5675437d-ea6 | |||
| a secret belongs to. The stable prefix allows operators to understand how often a secret has been modified and group secrets by connections. | |||
| 3. Not all secrets can be associated to a workspace e.g. Secrets created as part of a [Discover](./airbyte-protocol/#discover) or [Check](./airbyte-protocol/#check) operation. These secrets have a workspace id of | |||
| `00000000-0000-0000-0000-000000000000`. Whenever possible, Airbyte attempts to expire these secrets after 2 hours for security and cost reasons. | |||
| 4. Airbyte deletes old secrets when connector configuration is updated or deleted as of 0.63.10. | |||
There was a problem hiding this comment.
Suggested change
| 4. Airbyte deletes old secrets when connector configuration is updated or deleted as of 0.63.10. | |
| 4. When using Airbyte version 0.63.10 or higher, deleting a connection or updating the connector configuration deletes old secrets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update doc to reflect when connector secrets are deleted.
How
Update doc.
Review guide
The one file.
User Impact
Can this PR be safely reverted and rolled back?