-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source facebook-marketing: add friendly messages and tests #42562
Source facebook-marketing: add friendly messages and tests #42562
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…51-humanize-facebook-errors
/approve-regression-tests
|
Hi @aldogonzalez8 , I'm seeing the message Does this message mean there are too many fields being requested across the connection, or within a given stream? These are the parameters being requested for the stream that is surfacing the error, and it's surprising this is the error given the small number of streams.
If the user wants to sync all the fields, do you think the following options are equally viable to resolving the issue?
Or is one option a better alternative to the other? |
@nataliekwong Each of these streams is failing, so I think it is possible that even if you split the connection, you will see the problem again. Still, actually, I would try that first as we are not sure what is exactly the problem or how FB API will determine to throw that error (they never told us) but also that was always something possible and still we needed to have this other change. If you still have the error, then I would try to start unselecting fields; I am not sure if this problem is caused by the account asking for too much data or individual call level, but at least now we can try both approaches. Also, can you let us know how it goes? It seems something we can document.
|
What
Issues ref:
How
Add friendly messages to traced_exception handler.
Review guide
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/common.py
: add new friendly messages for "reducing fields" and "start date" errors.airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_errors.py
: new tests to cover these scenarios.User Impact
Users will read friendly errors when sync fails.
Can this PR be safely reverted and rolled back?