Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add display-name to enterprise implementation guide #42570

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

josephkmh
Copy link
Contributor

What

Updates the Enterprise Implementation Guide to account for this PR which allows users to optionally define a custom display-name for their OIDC app.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@josephkmh josephkmh requested review from hchiao1 and Hesperide July 26, 2024 17:03
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 5:06pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 26, 2024
@josephkmh josephkmh changed the title fix: add display-name to docs chore: add display-name to enterprise implementation guide Jul 26, 2024
Copy link
Contributor

@Hesperide Hesperide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@josephkmh josephkmh merged commit 26e4905 into master Jul 26, 2024
31 checks passed
@josephkmh josephkmh deleted the joey/display-name-oidc-setup branch July 26, 2024 17:23
Copy link

@hchiao1 hchiao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and I appreciate the help again

jtruty pushed a commit to jtruty/airbyte that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants