Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix mssql #42943

Merged
merged 4 commits into from
Aug 1, 2024
Merged

attempt to fix mssql #42943

merged 4 commits into from
Aug 1, 2024

Conversation

xiaohansong
Copy link
Contributor

@xiaohansong xiaohansong commented Aug 1, 2024

What

microsoft says:

Note: In SQL Server 2022 (16.x) CU 14 and later versions, container images include the new mssql-tools18 package. The previous directory /opt/mssql-tools/bin is being phased out. The new directory for Microsoft ODBC 18 tools is /opt/mssql-tools18/bin, aligning with the latest tools offering. For more information about changes and security enhancements, see ODBC Driver 18.0 for SQL Server Released. ODBC driver version 18 is designed with an encryption-first approach, ensuring that utilities like sqlcmd and bcp, which utilize the Microsoft ODBC driver, operate under the secure by default principle. Users who wish to disable encryption must do so explicitly.

https://mcr.microsoft.com/en-us/product/mssql/server/about

I think we should just use a fixed version of mssql in test rather than latest so it won't break our test infra anymore. If using latest is desired, we need to change this line

s/mssql-tools/mssql-tools18/g

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 10:21pm

@xiaohansong xiaohansong marked this pull request as ready for review August 1, 2024 20:43
@xiaohansong xiaohansong requested a review from a team as a code owner August 1, 2024 20:43
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving in case the test works 🤞

Copy link
Contributor

@theyueli theyueli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@xiaohansong xiaohansong merged commit 7e9fbc5 into master Aug 1, 2024
34 checks passed
@xiaohansong xiaohansong deleted the xiaohan/mssqlfix branch August 1, 2024 22:57
BenGalewsky pushed a commit to BenGalewsky/airbyte that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants