Destinations CDK: Property test for refreshes #43460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 9, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/expected_broken_bigquery_tests
branch
from
be63bdc to
0ccf677
Compare
edgao
force-pushed
the
edgao/refresh_massive_test
branch
from
7d4f94e to
4c8180c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partly a hackdays thing to try out kotest, partly an actual test implementation)
I'm leaning towards not actually merging this PR. It's pretty annoying to debug test failures. But I do feel convinced that we've handled a lot more edge cases now. (#42503 is passing this test fully). Curious what other folks think.
Taking nearly 40 seconds to run a unit test (literally no IO) is also pretty absurd. I think this is mostly from all the logging...
also, for the record - this generated 285,336 unique, valid test cases. Which is... probably untenable to do as an integration test