🐛 Source tiktok-marketing: fix include deleted option #44048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
the
area/documentation
girarda
approved these changes
Aug 15, 2024
| @@ -343,6 +343,42 @@ def test_read_with_state(self, http_mocker: HttpMocker): | |||
| {"cursor": {"stat_time_hour": self.cursor}, "partition": {"advertiser_id": self.advertiser_id, "parent_slice": {}}} | |||
| ] | |||
|
|
|||
| @HttpMocker() | |||
| def test_read_with_include_deleted(self, http_mocker: HttpMocker): | |||
There was a problem hiding this comment.
thanks for all the tests 🐟
aldogonzalez8
deleted the
aldogonzalez8/source/tik-tok-marketing/fix-include-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is related to https://github.com/airbytehq/oncall/issues/5205
According to documentation and @tolik0 investigation, now the "filters," param was changed to "filtering." Also, it won't ignore the incorrect "field_name" when filtering as it used to do, so it needs to pass the correct one for each data level.
How
Update yaml to use filtering when available and required.
Review guide
airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/manifest.yaml: changes removing filters and adding filtering param with correct field_name.airbyte-integrations/connectors/source-tiktok-marketing/unit_tests/integration/test_reports_hourly.py: new testing for filtering wheninclude_deletedis true in config.User Impact
When fetching streams ad_groups_reports_daily and ads_reports_daily from TikTok Marketing connector and putting "Include deleted data in reports" toggle on the user get the deleted ad_groups and ads (respectively).
Can this PR be safely reverted and rolled back?