Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Klaviyo: Add field[metrics] to events stream #44366

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Closes #44365

How

Added field[metrics], and include metric request parameter
Reference documentation:
https://developers.klaviyo.com/en/reference/get_events

@btkcodedev btkcodedev self-assigned this Aug 17, 2024
Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 0:34am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo labels Aug 17, 2024
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 17, 2024

Tested with postman and found no errors while adding the parameters
image

@natikgadzhi
Copy link
Contributor

Good issue to use as an example and figure out transparent access to regression test reports. This PR drops 974 out of 2700ish records ;-) so it's broken, but to best show you what's broken, we should open up the reports.

I'll see how to get this into your hands quickly.

@natikgadzhi
Copy link
Contributor

@btkcodedev resolve the conflicts please — a sneaky deps update added 2.9.4 before this got merged. Could be easier to go for 2.10!

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 22, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2aab476)

@btkcodedev
Copy link
Collaborator Author

@natikgadzhi Fixes applied and CI green, Please continue merge

@btkcodedev btkcodedev requested a review from natikgadzhi August 22, 2024 15:27
@natikgadzhi natikgadzhi merged commit a5707cd into master Aug 22, 2024
36 checks passed
@natikgadzhi natikgadzhi deleted the btkcodedev/klaviyoAddfieldmetric branch August 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klaviyo source: add field[metrics] to events stream
3 participants