-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Datadog: Update CDK version and dependencies, remove parameters and migrate to inline schemas #44371
Source Datadog: Update CDK version and dependencies, remove parameters and migrate to inline schemas #44371
Changes from all commits
3ee0af5
ad30408
8a34a6b
dae8502
7304233
94a4dd1
a743965
fb94e1a
7b42d8a
2d3056f
3950a95
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ acceptance_tests: | |
spec: | ||
tests: | ||
- spec_path: "source_datadog/spec.yaml" | ||
backward_compatibility_tests_config: | ||
disable_for_version: "0.4.15" # Set default start and end date for incremental sync | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In theory, you only want to disable the backwards compatibility tests if the new version will not work, but the old one worked. If the new version provides defaults and works in a scenario when a new one does not, why would it be broken? Also, usually if you're skipping backwards compat checks, this should signal that the change is breaking, which this is not. BUT, your build step in CI is failing on something something date can't be parsed something, so seems relevant. |
||
connection: | ||
tests: | ||
- config_path: "secrets/config.json" | ||
|
@@ -25,6 +27,8 @@ acceptance_tests: | |
bypass_reason: Sandbox account can't seed this stream | ||
- name: service_level_objectives | ||
bypass_reason: Sandbox account can't seed this stream | ||
- name: logs | ||
bypass_reason: Sandbox account can't seed this stream | ||
incremental: | ||
bypass_reason: "This connector does not implement incremental sync" | ||
full_refresh: | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",] | |
build-backend = "poetry.core.masonry.api" | ||
|
||
[tool.poetry] | ||
version = "0.4.15" | ||
version = "1.0.0" | ||
name = "source-datadog" | ||
description = "Source implementation for Datadog." | ||
authors = [ "Airbyte <contact@airbyte.io>",] | ||
|
@@ -16,13 +16,13 @@ repository = "https://github.com/airbytehq/airbyte" | |
include = "source_datadog" | ||
|
||
[tool.poetry.dependencies] | ||
python = "^3.9,<3.12" | ||
airbyte-cdk = "^1" | ||
python = "^3.10,<3.12" | ||
airbyte-cdk = "^4" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feeling adventurous I see |
||
|
||
[tool.poetry.scripts] | ||
source-datadog = "source_datadog.run:run" | ||
|
||
[tool.poetry.group.dev.dependencies] | ||
requests-mock = "^1.9.3" | ||
pytest = "^6.2" | ||
pytest-mock = "^3.6.1" | ||
requests-mock = "*" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you! |
||
pytest = "*" | ||
pytest-mock = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the spec file, so the spec path here should lead to the manifest, I think. /cc @ChristoGrab