-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci) Run codeflash in on PRs modifying the Python CDK #44427
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3eee4cc
Install codeflash
girarda a085125
Add codeflash GHA
girarda bf2ffc8
Move to a poe task
girarda 477f35c
Add bubble sort
girarda 6d4573c
missing quote
girarda 179ee7e
Pass codeflash api key to airbyte ci
girarda 76777bd
pass the api key to airbyte-ci-tests
girarda 840278b
Add api key to inputs
girarda bf518e7
make the param required
girarda 2ea1e1f
try not passing the env var to see if it fails
girarda e40394a
Revert "try not passing the env var to see if it fails"
girarda 63d9820
Update airbyte-cdk/python/pyproject.toml
girarda 13eebab
Update airbyte-cdk/python/pyproject.toml
girarda 885adf1
Update .github/actions/run-airbyte-ci/action.yml
girarda e8c145f
verbose logging of poe task results
alafanechere 5db297e
revert back to a gha to confirm this worked
girarda 55e9c6e
reset
girarda 1491fee
format
girarda f40f52c
Merge branch 'master' into alex/codeflash_ci
girarda 600e8a8
reset
girarda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,12 @@ | ||||||||||||||||||
# Copyright (c) 2024 Airbyte, Inc., all rights reserved. | ||||||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||||
def sorter(arr): | ||||||||||||||||||
for i in range(len(arr)): | ||||||||||||||||||
# This is a diff | ||||||||||||||||||
for j in range(len(arr) - 1): | ||||||||||||||||||
if arr[j] > arr[j + 1]: | ||||||||||||||||||
temp = arr[j] | ||||||||||||||||||
arr[j] = arr[j + 1] | ||||||||||||||||||
arr[j + 1] = temp | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
return arr |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alafanechere am I missing something obvious here? After moving from a custom GHA to airbyte-ci, the workflow is failing because it can't access the
CODEFLASH_API_KEY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing one last change: the thing that would make
airbyte-ci
set this env var on the docker container running the poe task.It has to be defined in
[tool.airbyte-ci]
in thepyproject.toml
file. I'll add a suggestion comment below.