gradle: fix annoying ksp error, bump CDK dependencies #44473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
postamar
commented
Aug 20, 2024
| resolutionStrategy { | ||
| preferProjectModules() | ||
| } | ||
| } |
There was a problem hiding this comment.
this is what fixes the ksp conflicts
postamar
commented
Aug 20, 2024
| id 'com.google.devtools.ksp' version '2.0.0-1.0.24' apply false | ||
| id 'com.github.spotbugs' version '6.0.7' | ||
| id 'org.jetbrains.kotlin.jvm' version '2.0.0' | ||
| id 'com.google.devtools.ksp' version '2.0.0-1.0.24' |
There was a problem hiding this comment.
apply false was a bit stupid considering we apply these plugins in all projects like 10 lines below
theyueli
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, gradle barfs exception stack traces when building the Bulk CDK. This is due to problems resolving dependency conflicts in the ksp annotation processor classpath. This is just a code generator so these errors turn out to be just noise. This PR fixes this.
Since we're already messing with dependencies, this PR also bumps dependency versions in the Bulk CDK.