connector-insights: use SPDX SBOM generated on publish #44493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-21-connector-insights_use_SPDX_SBOM_generated_on_publish
branch
from
dc1fd81 to
b596d8c
Compare
alafanechere
force-pushed
the
augustin/08-21-connector-insights_use_SPDX_SBOM_generated_on_publish
branch
from
b596d8c to
89607b3
Compare
natikgadzhi
reviewed
Aug 21, 2024
Co-authored-by: Natik Gadzhi <natik@respawn.io>
natikgadzhi
approved these changes
Aug 21, 2024
| @@ -234,8 +240,7 @@ async def generate_insights_for_connector( | |||
| """ | |||
| logger = logging.getLogger(__name__) | |||
| insights_file = FileToPersist("insights.json") | |||
| sbom_file = FileToPersist("sbom.json") | |||
| files_to_persist = [insights_file, sbom_file] | |||
| files_to_persist = [insights_file] | |||
There was a problem hiding this comment.
Nit: if there's just one file, do we even need this list in a variable?
| @@ -6,6 +6,8 @@ | |||
| from pathlib import Path | |||
| from typing import TYPE_CHECKING | |||
|
|
|||
| import requests | |||
There was a problem hiding this comment.
Wait a second, how did that work before? Are requests used there or no?
There was a problem hiding this comment.
Yep, I don't think requests are used ?
natikgadzhi
reviewed
Aug 21, 2024
Comment on lines
8
to
+9
|
|
||
| import requests |
There was a problem hiding this comment.
Suggested change
| import requests |
alafanechere
deleted the
augustin/08-21-connector-insights_use_SPDX_SBOM_generated_on_publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/9343
SBOMs are not generated on publish and their URL is exposed in the connector registry.
We should fetch already generated SBOM in insights generation instead of generating SBOM at execution time.
How
connectors-insightssbom_urlproperty on theConnectorclass