Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 9173] add ERD files for source-bing-ads #44516

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Aug 21, 2024

What

Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/9173 for source-bing-ads

How

By running airbyte-ci --name=source-bing-ads generate-erd

The publish has been done as part of the airbyte-ci command executed locally.

User Impact

ERD is now available on https://dbdocs.io/airbyteio/source-bing-ads

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Aug 21, 2024 4:15pm

@girarda
Copy link
Contributor

girarda commented Aug 21, 2024

/approve-and-merge reason="initial commit to allow for contribution but has no impact on the behavior of the connector"

@octavia-approvington
Copy link
Contributor

It's time
fine lets go

@octavia-approvington octavia-approvington merged commit bf9df38 into master Aug 21, 2024
34 of 37 checks passed
@octavia-approvington octavia-approvington deleted the issue-9173/source-bing-ads-erd branch August 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants