Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk-cdk: fix bugs surfaced by CAT tests #44543

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Aug 22, 2024

What

I tried to get the CAT tests running on airbyte-enterprise today. There were a few failures which surfaced bugs in the Bulk CDK, which doesn't always emit STATE or TRACE ERROR messages when required during a READ.

How

Emit TRACE ERROR messages if the configured streams are bad.
Emit at least one STATE message for each stream with an input state.

Review guide

Commit by commit

User Impact

None

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@postamar postamar requested a review from a team as a code owner August 22, 2024 02:41
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Aug 22, 2024 2:41am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 22, 2024
@@ -57,7 +57,7 @@
}
},
"sourceStats": {
"recordCount": 2.0
"recordCount": 1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was wrong but we never noticed because we don't look at the expected state message too closely

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emit TRACE ERROR messages if the configured streams are bad.
Emit at least one STATE message for each stream with an input state.

Nice catches!

@postamar postamar merged commit ff6b1bb into master Aug 22, 2024
33 checks passed
@postamar postamar deleted the postamar/fix-bulk-cdk-bugs-surfaced-by-cat-tests branch August 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants