Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source nytimes: Migrate to manifest-only #44555

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Source nytimes: Migrate to manifest-only #44555

merged 1 commit into from
Aug 22, 2024

Conversation

ChristoGrab
Copy link
Contributor

What

Migrates source-nytimes to manifest-only format

How

Used a script to run the airbyte-ci commands [migrate-to-manifest-only, bump-version, format fix, pull-request]

Review Guide

  1. manifest.yaml: should be at the root level of the folder, list version 4.3.0, contain an inlined spec, and all $parameters should be resolved.
  2. metadata.py: should list the correct manifest-only language tag, have pypi disabled, and point to a recent version of source-declarative-manifest
  3. acceptance-test-config.yml: should correctly point to manifest.yaml for the spec test
  4. readme.md: Should be updated with correct references to the connector
  5. Pretty much everything else should be nuked

User Impact

None

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 4:05pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 22, 2024
@ChristoGrab ChristoGrab force-pushed the christo/nytimes-manifest-only branch from 5688d21 to 91c03b5 Compare August 22, 2024 15:56
@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 22, 2024 15:57
@natikgadzhi natikgadzhi merged commit f0c0db5 into master Aug 22, 2024
34 of 35 checks passed
@natikgadzhi natikgadzhi deleted the christo/nytimes-manifest-only branch August 22, 2024 18:22
natikgadzhi
natikgadzhi reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

Let's wait for this to publish and see how that works

@natikgadzhi
Copy link
Contributor

I've pasted this in Builder, and it opened up correctly! <3

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/nytimes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristoGrab @natikgadzhi @octavia-squidington-iii