Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source breezometer: Migrate to manifest-only #44563

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Source breezometer: Migrate to manifest-only #44563

merged 2 commits into from
Aug 23, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Aug 22, 2024 •
edited
Loading

What

Migrates source-breezometer to manifest-only format

How

Used a script to run the airbyte-ci commands [migrate-to-inline_schemas, migrate-to-manifest-only, bump-version, format fix, pull-request]

Review Guide

  1. manifest.yaml: should be at the root level of the folder, list version 4.3.0, contain an inlined spec, and all $parameters should be resolved.
  2. metadata.py: should list the correct manifest-only language tag, have pypi disabled, and point to a recent version of source-declarative-manifest
  3. acceptance-test-config.yml: should correctly point to manifest.yaml for the spec test
  4. readme.md: Should be updated with correct references to the connector
  5. Pretty much everything else should be nuked

User Impact

None

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:35pm

@ChristoGrab ChristoGrab force-pushed the christo/breezometer-manifest-only branch from 4cadf21 to 697e780 Compare August 22, 2024 20:26
@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 22, 2024 20:28
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 22, 2024
@airbyteio airbyteio merged commit 1c25eca into master Aug 23, 2024
36 of 37 checks passed
@airbyteio airbyteio deleted the christo/breezometer-manifest-only branch August 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation auto-merge connectors/source/breezometer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristoGrab @octavia-squidington-iii @airbyteio