Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-reddit contribution from btkcodedev #44579

Merged
merged 17 commits into from
Aug 27, 2024
Merged

source-reddit contribution from btkcodedev #44579

merged 17 commits into from
Aug 27, 2024

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Aug 23, 2024 •
edited
Loading

Closes #44561
Auto-generated PR by the Connector Builder for source-reddit

@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 6:31pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 23, 2024
@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 23, 2024 05:58 — with GitHub Actions Inactive
@btkcodedev btkcodedev self-assigned this Aug 23, 2024
@btkcodedev
Revert "kyriba connector"
3111f66 
This reverts commit 7456007.
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 23, 2024 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (9c56bfa)

@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 23, 2024 16:54 — with GitHub Actions Inactive
erohmensing
erohmensing suggested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to size the icons according to our style guide.

@nora-airbyte is there a straightforward way for someone not in Figma to do this?

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 23, 2024 •
edited
Loading

@erohmensing We've got svg height and width attributes in icon.svg
Does that help?

btkcodedev and others added 2 commits August 26, 2024 23:39
@btkcodedev @erohmensing
Update airbyte-integrations/connectors/source-reddit/metadata.yaml
7c23d97 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@btkcodedev @erohmensing
Update docs/integrations/sources/reddit.md
2aa824d 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
btkcodedev and others added 2 commits August 26, 2024 23:39
@btkcodedev @erohmensing
Update docs/integrations/sources/reddit.md
c16c3b0 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@btkcodedev @erohmensing
Update docs/integrations/sources/reddit.md
990f228 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@btkcodedev @erohmensing
Update docs/integrations/sources/reddit.md
f48ee18 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 26, 2024 18:12 — with GitHub Actions Inactive
@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 26, 2024 18:12 — with GitHub Actions Inactive
@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 26, 2024 18:27 — with GitHub Actions Inactive
@btkcodedev btkcodedev temporarily deployed to community-ci-auto August 26, 2024 18:27 — with GitHub Actions Inactive
@natikgadzhi natikgadzhi merged commit 49e9bc9 into airbytehq:master Aug 27, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/reddit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎉New Source: Reddit
6 participants
@btkcodedev @erohmensing @nora-airbyte @natikgadzhi @octavia-squidington-iii @octavia-approvington