metadata-service[lib]: skip dockerImageTag decrement validation on pre-release #44580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
from
0cfb0e9 to
cc21917
Compare
octavia-squidington-iii
added
area/connectors
alafanechere
force-pushed
the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
2 times, most recently
from
d607f93 to
8d561b5
Compare
alafanechere
changed the title
alafanechere
force-pushed
the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
from
8d561b5 to
bf32e44
Compare
alafanechere
commented
Aug 23, 2024
| return False, f"The dockerImageTag value can't be decremented: it should be equal to or above {latest_released_version}." | ||
| return ( | ||
| False, | ||
| f"The dockerImageTag value ({current_semver_version}) can't be decremented: it should be equal to or above {latest_released_version}.", |
There was a problem hiding this comment.
Change changing the error message for easier debugging
girarda
approved these changes
Aug 23, 2024
alafanechere
force-pushed
the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
from
bf32e44 to
77eb834
Compare
alafanechere
force-pushed
the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
from
77eb834 to
9b787a6
Compare
alafanechere
deleted the
augustin/08-23-metadata-service_lib_fix_dockerImageTag_decrement_validator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On pre-release the process responsible for uploading the metadata patches the
dockerImageTagwith a.dev<sha>suffix.When we run the second metadata validation, before upload, the pre-release version is compared to the latest version.
The semver packages consider this version as lower than the latest one as it considers its a pre-release of the latest version (which should usually be released before the main version). This is logically correct.
This PR bypasses this validation on pre-release as it's useless to have it in a pre-release / testing context.