Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-high-level contribution from Stockotaco #44596

Conversation

Stockotaco
Copy link
Contributor

@Stockotaco Stockotaco commented Aug 23, 2024

Thanks for your contribution to the Airbyte Marketplace, @Stockotaco!

Please complete the following items, which we aim to automate soon:

  • Update the list of allowedHosts in metadata.yaml to include only the list of host domains your connector should have access to.
  • Delete empty lines between rows in the list of streams in the generated doc file
  • If you'd like to upload an icon for your connector, upload an SVG file into a comment on the PR - Your reviewer will help with sizing it appropriately. If you don't have an icon and want to keep the Airbyte icon, just check this box to indicate that.

There are two ways to address this:

  1. You can go into your PR, and edit files in the web UI directly
  2. You can fetch the Stockotaco:Stockotaco/builder-contribute/source-high-level branch and edit locally

Once you've done this, a reviewer will take a look. Reviewer, please:

  • Run the /format-fix slash command to fix any formatting issues

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 6:45pm

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

@ChristoGrab
Copy link
Contributor

ChristoGrab commented Aug 23, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (ce29960)

@erohmensing
Copy link
Contributor

erohmensing commented Aug 23, 2024

high-level (3)

This is the SVG file pre-resizing

@nora-airbyte
Copy link
Contributor

no-bg
blue-bg

Resized + cleaned up icon. We don't have icons with a full coverage background, so created two options here: a partial coverage bg and a transparent bg.

docs/integrations/sources/high-level.md Outdated Show resolved Hide resolved
docs/integrations/sources/high-level.md Outdated Show resolved Hide resolved
docs/integrations/sources/high-level.md Outdated Show resolved Hide resolved
@erohmensing erohmensing temporarily deployed to community-ci-auto August 26, 2024 18:41 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to community-ci-auto August 26, 2024 18:41 — with GitHub Actions Inactive
@erohmensing erohmensing merged commit fb6156c into airbytehq:master Aug 26, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/high-level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants