bulk-cdk: add more exception classifier implementations, add extra checks #44824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
postamar
commented
Aug 27, 2024
| check: | ||
| jdbc: | ||
| queries: | ||
| - SELECT DATABASE_PATH() FROM DUAL |
There was a problem hiding this comment.
this returns NULL For in-memory H2 database instances, which is what we use in our tests
xiaohansong
approved these changes
Aug 27, 2024
| } | ||
| } | ||
| /** Convenience val for [getOrder]. */ | ||
| val orderValue: Int |
There was a problem hiding this comment.
nice I like this - enables us to override some specific errors.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds:
JdbcExceptionClassifier, the vendor code rules are read fromapplication.yml;RegexExceptionClassifierwhich replicates most of the functionality in the legacy CDK, except that here again the rule definitions are read fromapplication.ymlinstead of being defined programmatically;CheckOperationwhich for JDBC sources are implemented byJdbcCheckQuerieswhich execute a sequence of SQL queries (also defined inapplication.yml) and if any of them return anything, that's thrown as aConfigErrorException.This is required for airbyte-enterprise connector certification.
Informs https://github.com/airbytehq/airbyte-internal-issues/issues/9457
Informs https://github.com/airbytehq/airbyte-internal-issues/issues/9373
How
Micronaut makes it easy to defined strongly-typed object instances in a yaml file. Thanks, Micronaut!
Review guide
Commit by commit.
User Impact
None
Can this PR be safely reverted and rolled back?