-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 docs: Enable ERDs for 10 top sources. #45085
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm!
I think we should have a hover state on the image in addition to the cursor change, but (a) I don't see designs for that and (b) I also see a handful of places in the docs that don't have a hover state, so not a blocking comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. I'll force merge this given that:
- No connector code was changed
- CI failures are not on QA checks (which is the only test suite validating the docs)
- CAT failures also exist on master.
/approve-and-merge reason="CI failures unrelated to the code change." |
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/9174
What
<ErdDiagram/>
which can be added to each connector once a ERD has been generated for that connector using dbdocs.How
User Impact
Users will now be able to check ERD diagrams for some sources.
Can this PR be safely reverted and rolled back?