Unit tests for streams manager #45090
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
johnny-schmidt
force-pushed
the
issue-9615/load-cdk-unit-tests-streams-manager
branch
from
322e28a to
8a98da0
Compare
johnny-schmidt
force-pushed
the
issue-9615/load-cdk-unit-tests-streams-manager
branch
from
8a98da0 to
d635c2c
Compare
| @@ -33,68 +35,98 @@ class DefaultStreamsManager( | |||
| return streamManagers[stream] ?: throw IllegalArgumentException("Stream not found: $stream") | |||
| } | |||
|
|
|||
| override suspend fun awaitAllStreamsComplete() { | |||
| override suspend fun awaitAllStreamsClosed() { | |||
| streamManagers.forEach { (_, manager) -> manager.awaitStreamClosed() } | |||
There was a problem hiding this comment.
TODO: error handling
| * Count the end-of-stream. Expect this exactly once. Expect no further `countRecordIn`, and | ||
| * expect that `markClosed` will always occur after this. | ||
| */ | ||
| fun countEndOfStream(): Long |
There was a problem hiding this comment.
that's a weird name. I'm not really sure what "counting the end of stream" means. Total number of records in the stream?
There was a problem hiding this comment.
I understand when reading further.
I think the notion of "counting" is off here. I don't expect count to increment a counter. We can leave it as is for now
| streamManagers.forEach { (_, manager) -> manager.awaitStreamClosed() } | ||
| } | ||
| } | ||
|
|
||
| /** Manages the state of a single stream. */ | ||
| interface StreamManager { | ||
| fun countRecordIn(sizeBytes: Long): Long | ||
| /** Count incoming record and return the record's *index*. */ |
There was a problem hiding this comment.
It looks to me like most of the functions here are setting state on the stream itself. Maybe this is just part of a Stream?
| listOf( | ||
| Pair(stream1, SetRecordCount(10)), | ||
| Pair(stream1, AddPersisted(0, 9)), | ||
| Pair(stream1, ExpectPersistedUntil(9)), |
There was a problem hiding this comment.
this is a bit confusing. Is the persistedUntil the message number or message count?
johnny-schmidt
deleted the
issue-9615/load-cdk-unit-tests-streams-manager
branch
What
@Named)