Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-getlago): ignore 405 response for customer usage #45193

Merged

Conversation

sviande
Copy link
Contributor

@sviande sviande commented Sep 6, 2024

What

GetLago return a http 405 status code if the customer doesn't have any active subscription see https://github.com/getlago/lago-api/blob/1cc20119783ba9ffcec99071cb0fa4ff3d1752d2/spec/services/invoices/customer_usage_service_spec.rb#L282

How

Ignore the 405 status with the code no_active_subscription

Review guide

Import a customer who has no recorded usage.

User Impact

Prevent error when a customer has no active subscription

Can this PR be safely reverted and rolled back?

  • [X ] YES 💚
  • NO ❌

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 6:05pm

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Sep 6, 2024
@sviande sviande temporarily deployed to community-ci-auto September 6, 2024 14:17 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 6, 2024 14:17 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm changed the title Connector getLago: ignore 405 response for customer usage feat(source-getlago): ignore 405 response for customer usage Sep 7, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @sviande !

@marcosmarxm marcosmarxm merged commit 52744ec into airbytehq:master Sep 9, 2024
34 checks passed
@sviande sviande deleted the connector_get_lago_fix_customer_usage branch September 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/getlago
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants