[source-us-census] fix empty fields after sync #45331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe/us-census/fix-empty-fields
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
1 task
octavia-squidington-iii
added
area/connectors
topefolorunso
changed the title
|
/format-fix
|
girarda
reviewed
Sep 7, 2024
|
|
||
| config: Config | ||
|
|
||
| def get_json_schema(self) -> Mapping[str, Any]: |
There was a problem hiding this comment.
@topefolorunso can you add some unit tests to verify this works as expected?
There was a problem hiding this comment.
Tests added now @girarda
|
/format-fix
|
natikgadzhi
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the empty records returned by syncing from the source
How
Defining the schema depending on the
query_paramsconfigReview guide
User Impact
Records will now be synced.
Can this PR be safely reverted and rolled back?