-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logging of unhandled debezium events #45368
Merged
rodireich
merged 6 commits into
master
from
9743-stop-logging-full-contents-of-dropped-debezium-records
Sep 10, 2024
Merged
Remove logging of unhandled debezium events #45368
rodireich
merged 6 commits into
master
from
9743-stop-logging-full-contents-of-dropped-debezium-records
Sep 10, 2024
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
CDK
Connector Development Kit
connectors/source/mssql
labels
Sep 10, 2024
Loading status checks…
…-debezium-records
rodireich
changed the title
remove logging of un handled debezium events
Remove logging of un handled debezium events
Sep 10, 2024
rodireich
changed the title
Remove logging of un handled debezium events
Remove logging of unhandled debezium events
Sep 10, 2024
benmoriceau
reviewed
Sep 10, 2024
...ces/src/main/kotlin/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordIterator.kt
Outdated
Show resolved
Hide resolved
xiaohansong
approved these changes
Sep 10, 2024
Loading status checks…
…-debezium-records
Contributor
Author
/publish-java-cdk dry-run=true
|
Contributor
Author
/publish-java-cdk
|
rodireich
deleted the
9743-stop-logging-full-contents-of-dropped-debezium-records
branch
September 10, 2024 20:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
CDK
Connector Development Kit
connectors/source/mssql
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Unhandled debezium event type are currently logging their entire content which is causing excessive logging and may also expose PII
How
Only log the offending event type without contents .
Can this PR be safely reverted and rolled back?