Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging of unhandled debezium events #45368

Merged

Conversation

rodireich
Copy link
Contributor

What

Unhandled debezium event type are currently logging their entire content which is causing excessive logging and may also expose PII

How

Only log the offending event type without contents .

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
jnels124 Jesse Nelson
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 8:41pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mssql labels Sep 10, 2024
…-debezium-records
@rodireich rodireich marked this pull request as ready for review September 10, 2024 18:28
@rodireich rodireich requested review from a team as code owners September 10, 2024 18:28
@rodireich rodireich changed the title remove logging of un handled debezium events Remove logging of un handled debezium events Sep 10, 2024
@rodireich rodireich changed the title Remove logging of un handled debezium events Remove logging of unhandled debezium events Sep 10, 2024
…-debezium-records
@rodireich
Copy link
Contributor Author

rodireich commented Sep 10, 2024

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/10799876907
✅ Successfully published Java CDK version=0.44.22!

@rodireich
Copy link
Contributor Author

rodireich commented Sep 10, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10800229606
✅ Successfully published Java CDK version=0.44.22!

@rodireich rodireich enabled auto-merge (squash) September 10, 2024 20:51
@rodireich rodireich merged commit 41a242b into master Sep 10, 2024
34 checks passed
@rodireich rodireich deleted the 9743-stop-logging-full-contents-of-dropped-debezium-records branch September 10, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mssql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants