Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-s3: fix tests #46281

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Oct 1, 2024

What

fixing tests

How

  • Updated the DestinationAcceptanceTest to use the new global shared state format
  • Modified test fixtures to use the new state message structure
  • Updated the S3 destination to use local CDK dependencies
  • Incremented the docker image tag to 1.3.0
  • Removed the main method from S3Destination class
  • Enhanced S3StorageOperationsIntegrationTest to track inserted files by generation ID

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:31pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Oct 1, 2024
Copy link
Contributor Author

stephane-airbyte commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch 2 times, most recently from 75fe0cb to a378bc2 Compare October 1, 2024 00:13
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 1, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from a378bc2 to f2cb461 Compare October 1, 2024 23:33
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from f2cb461 to 9861dee Compare October 3, 2024 15:58
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 9861dee to df089e5 Compare October 7, 2024 22:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from df089e5 to dfe525f Compare October 8, 2024 18:27
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from dfe525f to 78d6139 Compare October 9, 2024 20:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 78d6139 to bc6ef01 Compare October 11, 2024 19:23
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from bc6ef01 to b9b9f38 Compare October 11, 2024 21:30
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from b9b9f38 to cb14c97 Compare October 15, 2024 18:42
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from cb14c97 to 600dc83 Compare October 15, 2024 18:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 600dc83 to 37e76ad Compare October 15, 2024 18:54
@stephane-airbyte stephane-airbyte changed the title cdk-java: add file transfer mount to DestinationAcceptanceTest destination-s3: fix tests Oct 15, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 37e76ad to fe47fe5 Compare October 17, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from fe47fe5 to a0f15ff Compare October 21, 2024 22:14
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from a0f15ff to 3900b18 Compare October 23, 2024 14:26
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 3900b18 to 1896db6 Compare October 23, 2024 17:00
@stephane-airbyte stephane-airbyte marked this pull request as ready for review October 23, 2024 21:57
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner October 23, 2024 21:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from 1896db6 to e6fe5d4 Compare October 23, 2024 21:59
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch from e6fe5d4 to af110ce Compare October 23, 2024 22:26
Copy link

coderabbitai bot commented Oct 23, 2024


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor Author

stephane-airbyte commented Oct 23, 2024

Merge activity

  • Oct 23, 7:05 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 23, 7:05 PM EDT: A user merged this pull request with Graphite.

@stephane-airbyte stephane-airbyte merged commit 316e708 into master Oct 23, 2024
40 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/09-30-cdk-java_add_file_transfer_mount_to_destinationacceptancetest branch October 23, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants