Bulk Load CDK: Restore CheckpointManager Test #46321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
edgao
approved these changes
Oct 3, 2024
johnny-schmidt
force-pushed
the
jschmidt/issue-9970/load-cdk-checkpoint-manager-part-one
branch
3 times, most recently
from
2c5baa8 to
3c8a97e
Compare
Base automatically changed from
jschmidt/issue-9970/load-cdk-checkpoint-manager-part-one
to
master
October 3, 2024 21:48
johnny-schmidt
force-pushed
the
jschmidt/issue-9970/load-cdk-checkpoint-manager-part-two
branch
from
85cae03 to
663d21c
Compare
johnny-schmidt
force-pushed
the
jschmidt/issue-9970/load-cdk-checkpoint-manager-part-two
branch
from
663d21c to
466fe14
Compare
johnny-schmidt
deleted the
jschmidt/issue-9970/load-cdk-checkpoint-manager-part-two
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restores the broken CheckpointManagerTest (by removing
suspend, which was confoundingParameterizedTest).Additionally, this required test changes to keep it working: basically, because I removed the mocks for Sync/Stream manager, I had to manipulate the state from the outside a little (like, if the test case said index 10, I had to advance the record count 10 times, etc). This makes the test more realistic.
Also I switched it to
rebuildContext = trueso that the managers would get rest.Also I removed some stray println statements and (accidentally) picked up a test improvement I left out of the previous PR :)