Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(source-bing-ads): bump CDK #46991

Merged
merged 10 commits into from
Oct 23, 2024
Merged

perf(source-bing-ads): bump CDK #46991

merged 10 commits into from
Oct 23, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Oct 18, 2024 •
edited
Loading

What

Resolving https://github.com/airbytehq/product-request-backlog/issues/306

How

  • bump CDK version
  • fix CAT: read to file directly to pass dagger size limitations (128MB)

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@artem1205
Source Bing Ads: bump CDK
2a23f9c 
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Oct 18, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 8:23am

@artem1205
Source Bing Ads: update docs
b8211b9 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 18, 2024
@artem1205
Source Bing Ads: fix unit tests
43af285 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 requested a review from a team October 18, 2024 12:00
@artem1205 artem1205 marked this pull request as ready for review October 18, 2024 12:00
aldogonzalez8
aldogonzalez8 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@artem1205
Source Bing Ads: update exprected records
40ec1f5 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Merge remote-tracking branch 'origin/master' into artem1205/source-bi…
fa1dc14 
…ng-ads-bump-CDK
@artem1205
Source Bing Ads: update docs
7fa08db 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
artem1205 and others added 3 commits October 21, 2024 15:37
@artem1205
Source Bing Ads: update recs
5498db4 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Source Bing Ads: update recs
ce7ebe8 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
Merge branch 'master' into artem1205/source-bing-ads-bump-CDK
2b6263b
@artem1205
CAT: read to file directly to pass dagger size limitations (128MB)
6deef34 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 requested a review from a team as a code owner October 23, 2024 08:23
@artem1205
Copy link
Collaborator Author

artem1205 commented Oct 23, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@artem1205 artem1205 merged commit 246502e into master Oct 23, 2024
38 of 39 checks passed
@artem1205 artem1205 deleted the artem1205/source-bing-ads-bump-CDK branch October 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldogonzalez8 aldogonzalez8 aldogonzalez8 approved these changes

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem1205 @aldogonzalez8 @octavia-squidington-iii