Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow publishing airbyte-server to local maven repo #4717

Merged
merged 4 commits into from
Jul 13, 2021
Merged

allow publishing airbyte-server to local maven repo #4717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4fbedf
allow publishing airbyte-server to local maven repo
jrhizor Jul 13, 2021
68bccb8
Stub this out so the name that is created is airbyte-server-0.27.1-al…
davinchia Jul 13, 2021
e54159c
Add comments.
davinchia Jul 13, 2021
5648a6c
see if this fixes build
jrhizor Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ENV APPLICATION airbyte-server

WORKDIR /app

COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar
COPY build/distributions/${APPLICATION}-0*.tar ${APPLICATION}.tar

RUN mkdir latest_seeds
COPY build/config_init/resources/main/config latest_seeds
Expand Down
27 changes: 26 additions & 1 deletion airbyte-server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
plugins {
id 'application'
id 'maven-publish'
id 'com.github.johnrengelman.shadow' version '6.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadow is back!!!

}

shadowJar {
zip64 true
mergeServiceFiles()
exclude 'META-INF/*.RSA'
Copy link
Contributor

@davinchia davinchia Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these excludes doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes signed certificates, which may conflict from some packages.

exclude 'META-INF/*.SF'
exclude 'META-INF/*.DSA'
// Not stubbing this out adds 'all' to the end of the jar's name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhizor I had to add this so the names of the jars would line up. We either stub this out or we change the Cloud's dependency to be {module]-all.jar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it was able to consume the -all jar for me properly for me. Not sure what made it required for you but it's fine either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is for the server Docker build?

classifier = ''
}

publishing {
publications {
shadow(MavenPublication) { publication ->
project.shadow.component(publication)
}
}
repositories {
mavenLocal()
}
}

dependencies {
Expand Down Expand Up @@ -52,8 +75,10 @@ task copySeed(type: Copy, dependsOn: [project(':airbyte-config:init').processRes
//project.tasks.copySeed.mustRunAfter(project(':airbyte-config:init').tasks.processResources)
assemble.dependsOn(project.tasks.copySeed)

mainClassName = 'io.airbyte.server.ServerApp'

application {
mainClass = 'io.airbyte.server.ServerApp'
mainClass = mainClassName
}

Properties env = new Properties()
Expand Down