source-mssql: convert to bulk CDK #48465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
4 times, most recently
from
ff6891f to
5a4d483
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
2 times, most recently
from
a63db79 to
8bb623d
Compare
postamar
reviewed
Nov 13, 2024
| @@ -38,19 +38,6 @@ data: | |||
| message: "Add default cursor for cdc" | |||
| upgradeDeadline: "2023-08-23" | |||
| connectorTestSuitesOptions: | |||
| - suite: unitTests | |||
There was a problem hiding this comment.
I understand the removal of integrationTests but is removing unitTests intentional?
| import jakarta.inject.Singleton | ||
|
|
||
| /** | ||
| * The object which is mapped to the Mysql source configuration JSON. |
There was a problem hiding this comment.
please do a string search&replace for /mysql/mssql/ in this source tree before we forget to do so :)
| * Copyright (c) 2024 Airbyte, Inc., all rights reserved. | ||
| */ | ||
|
|
||
| package io.airbyte.integrations.source.mssql.config_spec |
There was a problem hiding this comment.
apparently underscores in package names makes some people sad
| @JsonSchemaInject(json = """{"order":8, "default":"CDC", "display_type": "radio"}""") | ||
| fun getReplicationMethodValue(): MsSqlServerReplicationMethodConfiguration? = | ||
| replicationMethodJson ?: replicationMethod.asReplicationMethod() | ||
| } |
There was a problem hiding this comment.
I skimmed over this and the rest of the package but it seems legit. If your unit tests are happy then I'm happy.
| @@ -321,7 +321,7 @@ data object UserDefinedCursor : CursorMethodConfiguration | |||
| @JsonSchemaDescription( | |||
| "<i>Recommended</i> - " + | |||
| "Incrementally reads new inserts, updates, and deletes using Mysql's <a href=" + | |||
| "\"https://docs.airbyte.com/integrations/sources/mssql/#change-data-capture-cdc\"" + | |||
| "\"https://docs.airbyte.com/integrations/sources/mysql/#change-data-capture-cdc\"" + | |||
There was a problem hiding this comment.
good catches! should these changes be in a separate PR? probably, because you'll have to bump the version of source-mysql
| }, | ||
| "additionalProperties": true | ||
| } | ||
| } |
There was a problem hiding this comment.
Hopefully this isn't too different from the legacy spec?
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
13 times, most recently
from
dd1bac8 to
2b752b8
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
4 times, most recently
from
0df7cbd to
c3296db
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
13 times, most recently
from
1fdf785 to
4c34884
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
2 times, most recently
from
067100e to
1058bcc
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
2 times, most recently
from
070288f to
b685ade
Compare
stephane-airbyte
force-pushed
the
stephane/11-12-source-mssql_convert_to_bulk_cdk
branch
from
b685ade to
f9e0271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?