[MotherDuck connector] fix: Pass config to connect_args in create_engine #48562
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guenp is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
guenp
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
guenp
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
/format-fix
|
octavia-approvington
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where the MotherDuck token is visibly logged by SQLAlchemy
How
Pass the MotherDuck token via the
configviacreate_engine'sconnect_argsso it's not logged by SQLAlchemyReview guide
User Impact
No longer logging the token in the stdout
Can this PR be safely reverted and rolled back?