-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source E-Commerce: fix start date parameter in spec #48564
Open
mombrea
wants to merge
5
commits into
airbytehq:master
Choose a base branch
from
mombrea:mombrea/fix-commercetools-date-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🐛 Source E-Commerce: fix start date parameter in spec #48564
mombrea
wants to merge
5
commits into
airbytehq:master
from
mombrea:mombrea/fix-commercetools-date-format
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mombrea is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
mombrea
temporarily deployed
to
community-ci-auto
November 19, 2024 21:15
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 19, 2024 21:15
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 13:41
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 13:41
— with
GitHub Actions
Inactive
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Nov 20, 2024
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 14:33
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 14:33
— with
GitHub Actions
Inactive
mombrea
changed the title
Source CommerceTools: JSON Schema start_date is self-conflicting; impossible to fill out.
🐛 Source E-Commerce: fix start date parameter in spec
Nov 20, 2024
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 18:58
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 20, 2024 18:58
— with
GitHub Actions
Inactive
mombrea
temporarily deployed
to
community-ci-auto
November 21, 2024 14:08
— with
GitHub Actions
Inactive
mombrea
requested a deployment
to
community-ci
November 21, 2024 14:08
— with
GitHub Actions
Waiting
mombrea
temporarily deployed
to
community-ci-auto
November 21, 2024 14:08
— with
GitHub Actions
Inactive
mombrea
requested a deployment
to
community-ci
November 21, 2024 14:08
— with
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/commercetools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #34133
Currently you cannot set up a commercetools source because the new connection form requires a Start Date in the date only format YYYY-MM-DD however the connection manifest requires a date-time format and is self conflicting.
How
The manifest spec has been updated to change the start_date property format to date
Review guide
User Impact
Users can now create commercetools source connections
Can this PR be safely reverted and rolled back?