chore: add generation id handling for iceberg #48568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
| @@ -27,13 +28,35 @@ import org.apache.iceberg.util.PropertyUtil | |||
| @Singleton | |||
| class IcebergTableWriterFactory { | |||
|
|
|||
| companion object { | |||
There was a problem hiding this comment.
Nit: we don't need to use a companion object for this stuff -- you can just make the class, regex and methods file-level objections. If we needed to expose these statically to Java code, then putting them in an object would be required. However, since all of this is Kotlin code, we don't need to do that here.
subodh1810
changed the base branch from
jonathan/iceberg-writer
to
jonathan/implement-iceberg-stream-loader
…genreation-id-logic
…genreation-id-logic
|
Tests passing locally, merging in |
subodh1810
merged commit f51173e
into
jonathan/implement-iceberg-stream-loader
17 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg generation id deletion