docs: fix refs to Python CDK manifest yaml #48576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
the
area/documentation
|
Another error:
Working on it... |
natikgadzhi
approved these changes
Nov 20, 2024
docs/connector-development/tutorials/the-hard-way/build-a-connector-the-hard-way.md
Show resolved
Hide resolved
|
@aaronsteers for the second build error — it's fine to link to the neighboring repo I think. |
|
@natikgadzhi - Thanks for the review. I've confirmed that merging this resolved the build failures. I ended up using your suggestion of copying back the yaml file that was imported. We don't support https imports. There's a potential path to do so here but it's non-trivial and I didn't want to introduce new factors or potential security considerations in this fix. I'll open a new issue as requested and assign to you. |
tryangul
pushed a commit
that referenced
this pull request
Nov 21, 2024
matteogp
pushed a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix docs build failures:
Slack thread: https://airbytehq-team.slack.com/archives/C032Y32T065/p1732034232793509
Also disables CDK Sphinx builds. We expect this is being replaced with pdoc docs.
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?