Re-sync in case of stale offset #48578
Merged
+75
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
rodireich
commented
Nov 20, 2024
| when (streamFeedBootstrap.currentState?.isEmpty) { | ||
| false -> streamFeedBootstrap.currentState!! | ||
| else -> return coldStart(streamState) | ||
| } |
There was a problem hiding this comment.
This fixes a bug:
When sync that includes a number of feeds with some that haven't started yet, during checkpoint those feeds will have a stream state of {}.
Stopping and restarting the sync need to treat them as a cold start. before this fix those {} feeds didn't do a snapshot.
|
While verifying this pr I noticed another bug that is not directly related to resync but has to do with how empty tables save their state.
Issue fixed in #48593 branched out of this PR. |
rodireich
changed the title
theyueli
reviewed
Nov 21, 2024
| if (CDCNeedsRestart) { | ||
| globalLockResource.markCdcAsComplete() | ||
| throw TransientErrorException( | ||
| "Saved offset no longer present on the server, Airbyte is going to trigger a sync from scratch." |
theyueli
approved these changes
Nov 21, 2024
rodireich
deleted the
10757-mysql-beta-verify-flow-for-stale-offset-with-re-sync-data
branch
tryangul
pushed a commit
that referenced
this pull request
Nov 21, 2024
frifriSF59
pushed a commit
that referenced
this pull request
Nov 21, 2024
matteogp
pushed a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With this change mysql will now correctly do a re-sync in case a saved CDC offset is found to be stale, and mysql is configured to go to resync rather than fail.
How
CDCPartitionsCreator goes into the following flow:
Review guide