Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination S3V2: Endpoint URL support #48764

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

johnny-schmidt
Copy link
Contributor

What

Forgot to knock this one out before the holiday.

Adds support for the endpoint url. Plus test case + secret.

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner December 2, 2024 17:20
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 1:58am

@johnny-schmidt johnny-schmidt removed the request for review from a team December 2, 2024 17:20
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Dec 2, 2024
@johnny-schmidt johnny-schmidt requested a review from a team December 2, 2024 17:21
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/endpoint-url-for-client branch from 846108c to b2999da Compare December 4, 2024 21:28
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/endpoint-url-for-client branch from b2999da to 1306554 Compare December 5, 2024 01:57
@johnny-schmidt johnny-schmidt enabled auto-merge (squash) December 5, 2024 01:57
@johnny-schmidt johnny-schmidt merged commit 8182b8e into master Dec 5, 2024
33 checks passed
@johnny-schmidt johnny-schmidt deleted the jschmidt/s3v2/endpoint-url-for-client branch December 5, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants