chore: Skeleton project for destination MSSQL V2 #49460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
edgao
approved these changes
Dec 13, 2024
|
|
||
| configurations.configureEach { | ||
| // Exclude additional SLF4J providers from all classpaths | ||
| exclude(mapOf("group" to "org.slf4j", "module" to "slf4j-reload4j")) |
There was a problem hiding this comment.
nonblocking, did we ever find where this dep is coming from? and/or we could add this exclude to the plugin (airbyte-bulk-connector.gradle)
There was a problem hiding this comment.
@edgao I would have to check. It may not be an issue in this destination (copy pasta here). If I recall correctly, it may have been one of the hadoop dependencies that we got via Iceberg and maybe even via the CDK because of parquet.
octavia-squidington-iii
removed
the
area/documentation
|
This is now good to merge. The airbyte-ci build is failing because we have not yet implemented some of the required interfaces (configuration, etc) |
gosusnp
approved these changes
Dec 13, 2024
octavia-squidington-iii
added
the
area/documentation
|
#49835 should address the last failure in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Can this PR be safely reverted and rolled back?