Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hoorayhr contribution from JoeriSmits #49836

Conversation

JoeriSmits
Copy link
Contributor

@JoeriSmits JoeriSmits commented Dec 17, 2024

What

This PR adds a new connector for source HoorayHR (source-hoorayhr).

Contributor-provided connector description:

Source connector for HoorayHR (https://hoorayhr.io). The connector uses https://api.hoorayhr.io

Details

Expand for list of spec properties and streams

Configuration

Input Type Description Default Value
hoorayhrpassword string HoorayHR Password.
hoorayhrusername string HoorayHR Username.

Streams

Stream Name Primary Key Pagination Supports Full Sync Supports Incremental
sick-leaves id No pagination
time-off id No pagination
leave-types id No pagination
users id No pagination

Reviewer checklist

  • Run /format-fix to resolve any formatting errors
  • Help the contributor upload an icon that follows our icon design guidelines
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Dec 17, 2024

@JoeriSmits is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:26am

@natikgadzhi
Copy link
Contributor

This is so nice! @JoeriSmits thank you for the connector!

Can you grab a square SVG icon for HoorayHR and upload it to icon.svg? Once that's done, I'm happy to merge.

@natikgadzhi natikgadzhi disabled auto-merge December 18, 2024 02:18
@natikgadzhi natikgadzhi merged commit c0f8679 into airbytehq:master Dec 18, 2024
20 of 21 checks passed
@JoeriSmits
Copy link
Contributor Author

Hi @natikgadzhi ,

Thanks for the merge. Does it takes some time for the connector to appear in the marketplace? I cannot see the source in the marketplace on my Airbyte instance yet.

@natikgadzhi
Copy link
Contributor

Around 15 minutes if things build correctly. On airbyte OSS you'd have to restart for it to pick up the new catalog.

@natikgadzhi
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/hoorayhr
Projects
Development

Successfully merging this pull request may close these issues.

4 participants