Make sample query compatible with views #50437
Open
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
theyueli
approved these changes
Dec 30, 2024
theyueli
reviewed
Dec 30, 2024
| @@ -9,7 +9,7 @@ data: | |||
| connectorSubtype: database | |||
| connectorType: source | |||
| definitionId: 435bb9a5-7887-4809-aa58-28c27df0d7ad | |||
| dockerImageTag: 3.10.0-rc.4 | |||
There was a problem hiding this comment.
i wondered why did we use rc tag in the previous version.. we could just use the minor version ...
postamar
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
One part of the table sample query was returning a null for a view, which is chosen as the
GREATESTby another part of the query, leading to incorrect identification of an empty table.How
Ensuring that a view is sampled correctly by using mysql's
COALESCE()function.User Impact
Views should be read correctly. A refresh of a view stream us recommended.
Can this PR be safely reverted and rolled back?