-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Source Pardot: Fix minor schema issues, improve data integrity by not using split-up interval, improve error retries #51040
Conversation
…schema-fixes-and-enhancements
@justbeez is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
@DanyloGL and @ChristoGrab, could you please check the contribution made by Justin? I believe you are assisting him on Slack. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mostly happy! Let's see if basic CI runs well and merge.
@natikgadzhi Need anything from me to get this one landed? |
Just some verbal encouragement <3 |
Hopefully kicked-off the CI, but will return to this later today and merge. |
There was a mismatch between the manifest and base image versions that caused a build failure; just bumped the base image in metadata, will keep an eye on the results |
Alright, there is a build error because the manifest wants CDK version that is newer than what is in the base image. We should update the base image to 6.22+ and that will work. |
Merging because the failure is complaining that we should have CATs |
…t using split-up interval, improve error retries (#51040) Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: ChristoGrab <christo.grab@gmail.com>
…t using split-up interval, improve error retries (#51040) Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: ChristoGrab <christo.grab@gmail.com>
What
This PR resolves several minor bugs related to the Pardot/Marketing Cloud Account Engagement connector:
custom_redirects
How
Changes to all streams:
Removed split-up interval option (which could lead to small data gaps on very high-volume accounts)
Added a constant backoff when the daily API limit is hit
Adjusted the default exponential backoff try count and factor to better handle transient errors seen in testing
Stream-specific updates:
campaigns
: added schema for missing fields to ensure type consistency across stream-level keyscustom_redirects
: fixed type ofsalesforceId
(which is a string, unlike the Pardot native IDs); applied date-time type tocreatedAt
; removed unneeded conditional query parametersemail_clicks
: switchedcreated_at
Airbyte type totimestamp_without_timezone
(the v4 API doesn't return timezone)folders
: applieddate-time
type tocreatedAt
andupdatedAt
list_emails
: applied date-time type tosentAt
account
: remove unneeded (but non-erroring) required field,createdAt
custom_fields
: ChangefieldId
to string type to prevent error; remove unneeded (but non-erroring) required field (createdAt
)dynamic_contents
: MakebasedOnProspectApiFieldId
string to avoid errorReview guide
Manifest and docs also updated accordingly.
User Impact
These are all non-breaking changes, and some fix errors that occur depending on the values of certain fields. Previously enabling these streams could result in a source error.
Can this PR be safely reverted and rolled back?