Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Facebook Marketing: Update to version 21 of the API #52032

Merged
merged 28 commits into from
Jan 29, 2025
Merged

✨ Source Facebook Marketing: Update to version 21 of the API #52032

merged 28 commits into from
Jan 29, 2025

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 20, 2025

What

Following #50852

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 3:24pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Jan 20, 2025
@DanyloGL DanyloGL mentioned this pull request Jan 23, 2025
Merged
2 tasks
@bazarnov bazarnov self-requested a review January 24, 2025 14:03
@maxi297 maxi297 requested a review from a team January 24, 2025 14:10
@bazarnov
Copy link
Collaborator

@maxi297 I believe we should be reflecting the spec change in this file as well: https://github.com/airbytehq/airbyte/blob/bnchrch/oauth/add-docs/airbyte-integrations/connectors/source-facebook-marketing/integration_tests/spec.json#L2

bazarnov
bazarnov approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking the merge, after the changes request. This is not a final approval.

@maxi297
Copy link
Contributor Author

maxi297 commented Jan 29, 2025 •
edited by github-actions bot
Loading

/approve-regression-tests done before the previous comment

Check job output.

✅ Approving regression tests

@DanyloGL DanyloGL merged commit bb47826 into master Jan 29, 2025
29 checks passed
@DanyloGL DanyloGL deleted the maxi297/facebook-marketing-update-to-api-version-21 branch January 29, 2025 17:11
@DanyloGL DanyloGL mentioned this pull request Jan 30, 2025
Closed
2 tasks
@marcosmarxm marcosmarxm mentioned this pull request Jan 30, 2025
Closed
1 task
btkcodedev pushed a commit that referenced this pull request Feb 3, 2025
@maxi297 @h0rban
@DanyloGL @btkcodedev
✨ Source Facebook Marketing: Update to version 21 of the API (#52032)
ea7c47f 
Co-authored-by: jake horban <j@portal.ai>
Co-authored-by: jake horban <jake.horban@gmail.com>
Co-authored-by: Danylo Jablonski <150933663+DanyloGL@users.noreply.github.com>
Co-authored-by: daniel.i.jablonski <daniel.i.jablonski@globallogic.com>
@natikgadzhi natikgadzhi mentioned this pull request Feb 3, 2025
Closed
1 task
stephane-airbyte pushed a commit that referenced this pull request Feb 4, 2025
@maxi297 @h0rban
@DanyloGL @stephane-airbyte
✨ Source Facebook Marketing: Update to version 21 of the API (#52032)
4f56ce4 
Co-authored-by: jake horban <j@portal.ai>
Co-authored-by: jake horban <jake.horban@gmail.com>
Co-authored-by: Danylo Jablonski <150933663+DanyloGL@users.noreply.github.com>
Co-authored-by: daniel.i.jablonski <daniel.i.jablonski@globallogic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxi297 @bazarnov @octavia-squidington-iii @DanyloGL @h0rban