Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination S3 Data Lake: handle stream with no records #52564

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Destination S3 Data Lake: handle stream with no records #52564

merged 3 commits into from
Jan 27, 2025

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 27, 2025

currently:

so now we do an explicit createBranch.

Also, add a no-records testcase to the base tests.

@edgao edgao requested a review from frifriSF59 January 27, 2025 16:08
@edgao edgao requested a review from a team as a code owner January 27, 2025 16:08
@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 4:55pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-data-lake labels Jan 27, 2025
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 27, 2025
frifriSF59
frifriSF59 reviewed Jan 27, 2025
View reviewed changes
.../load/src/testFixtures/kotlin/io/airbyte/cdk/load/write/BasicFunctionalityIntegrationTest.kt
@@ -2445,6 +2445,27 @@ abstract class BasicFunctionalityIntegrationTest(
)
}

@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

frifriSF59
frifriSF59 reviewed Jan 27, 2025
View reviewed changes
docs/integrations/destinations/s3-data-lake.md
@@ -17,7 +17,8 @@ for more information.

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------------------------------|
| 0.2.20 | 2025-01-32 | [\#52068](https://github.com/airbytehq/airbyte/pull/52068) | Add support for default namespace (/database name) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops

@edgao edgao merged commit 0a0a33f into master Jan 27, 2025
34 checks passed
@edgao edgao deleted the edgao/iceberg_empty_stream branch January 27, 2025 17:46
btkcodedev pushed a commit that referenced this pull request Feb 3, 2025
@edgao @btkcodedev
Destination S3 Data Lake: handle stream with no records (#52564)
161f576
stephane-airbyte pushed a commit that referenced this pull request Feb 4, 2025
@edgao @stephane-airbyte
Destination S3 Data Lake: handle stream with no records (#52564)
b1a0e78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frifriSF59 frifriSF59 frifriSF59 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @frifriSF59 @octavia-squidington-iii