Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add batch to insert records in MSSQL (2100 params limit) #5272

Merged
merged 7 commits into from
Aug 10, 2021
Merged

🐛 Add batch to insert records in MSSQL (2100 params limit) #5272

merged 7 commits into from
Aug 10, 2021

Conversation

marcosmarxm
Copy link
Member

What

Closes #4181

How

Break the insert function to work with batch limited to 700 records.

Recommended reading order

  1. SqlServerOperations.java

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 7, 2021
@marcosmarxm marcosmarxm requested a review from subodh1810 August 7, 2021 23:27
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 7, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1108896192
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1108896192

@jrhizor jrhizor temporarily deployed to more-secrets August 7, 2021 23:32 Inactive
sherifnada
sherifnada approved these changes Aug 8, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to protect against regressions?

subodh1810
subodh1810 reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@subodh1810 subodh1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start using BULK INSERT to load data in sql server like we do with other destinations. Not specific to this PR but just wanted to bring it up.

...ation-mssql/src/main/java/io/airbyte/integrations/destination/mssql/SqlServerOperations.java
try {
SqlOperationsUtils.insertRawRecordsInSingleQuery(insertQueryComponent, recordQueryComponent, database, record);
} catch (SQLException e) {
e.printStackTrace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we throw a RuntimeException right here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function insertRawRecordsInSingleQuery throws a SQLException

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he means this suggestion below:

Suggested change
e.printStackTrace();
throw new RuntimeException(e);

@marcosmarxm
Copy link
Member Author

I think we should start using BULK INSERT to load data in sql server like we do with other destinations. Not specific to this PR but just wanted to bring it up.

Thanks for the suggestion @subodh1810. I'll release this patch version to allow users the MSSQL destination for now.
I created a new issue to follow the bulk insert method: https://github.com/airbytehq/airbyte-internal-issues/issues/198

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115023295
❌ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115023295

@jrhizor jrhizor temporarily deployed to more-secrets August 10, 2021 02:04 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115113279
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115113279

@jrhizor jrhizor temporarily deployed to more-secrets August 10, 2021 02:47 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115163001
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1115163001

@jrhizor jrhizor temporarily deployed to more-secrets August 10, 2021 03:11 Inactive
@marcosmarxm marcosmarxm changed the title Add batch to insert records in MSSQL (2100 params limit) 🐛 Add batch to insert records in MSSQL (2100 params limit) Aug 10, 2021
@marcosmarxm marcosmarxm merged commit e9f4f37 into master Aug 10, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/mssql-2100-params branch August 10, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subodh1810 subodh1810 subodh1810 left review comments

@sherifnada sherifnada sherifnada approved these changes

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destination MSSQL: The server supports a maximum of 2100 parameters
4 participants
@marcosmarxm @sherifnada @subodh1810 @jrhizor