Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Intercom: Update with latest CDK features, remove custom incremental sync components #53187

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Source Intercom: Update with latest CDK features, remove custom incremental sync components #53187

wants to merge 16 commits into from

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Feb 5, 2025 •
edited
Loading

What

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11532

How

  • source-intercom is running on the latest version of CDK v6 (6.33.0+)
  • The companies stream does not use the IncrementalSingleSliceCursor
  • The contacts stream does not use the IncrementalSingleSliceCursor
  • The conversations stream does not use the IncrementalSingleSliceCursor
  • The segments stream does not use the IncrementalSingleSliceCursor
  • The company_segments stream does not use the IncrementalSubstreamSlicerCursor
  • The conversation_parts stream does not use the IncrementalSubstreamSlicerCursor
  • IncrementalSingleSliceCursor and IncrementalSubstreamSlicerCursor is deleted from components.py
  • All tests in /unit_tests pass.
  • All CI checks are passing ✅
  • Live traffic regression test suite run with passing results
  • Progressive rollout starting with 20%
  • Progressive rollout starting with 50%
  • Progressive rollout as main release of the candidate version

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 2:16am

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Feb 5, 2025 •
edited by github-actions bot
Loading

/bump-version type="minor" changelog="Update with latest CDK features, remove custom incremental sync components"

Bump Version job started... Check job output.

✅ Changes applied successfully. (1b27557)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 5, 2025
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Feb 5, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2584cfa)

@btkcodedev
Copy link
Collaborator Author

Removed parameters field, and other redundant fields for more compatibility with builder

@btkcodedev
Copy link
Collaborator Author

Removed the incremental custom components

@btkcodedev
Copy link
Collaborator Author

Tested with builder
Streams are fetching data, hashed within manifest

@btkcodedev
Copy link
Collaborator Author

image
Hashed at manifest: https://github.com/airbytehq/airbyte/pull/53187/files#diff-06642ea1714b19eda2e04aebb09a6c67f87162abc441a9548a9f5e144640e26fR948

@brianjlai
Copy link
Contributor

@DanyloGL let's get a regression test of intercom going when you have a moment

@btkcodedev btkcodedev mentioned this pull request Feb 11, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

@brianjlai brianjlai Awaiting requested review from brianjlai

@DanyloGL DanyloGL Awaiting requested review from DanyloGL

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/intercom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btkcodedev @brianjlai @octavia-squidington-iii